Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add concurrent usage when using endpoints in the worker #185

Open
russellb opened this issue Apr 9, 2024 · 1 comment
Open

Add concurrent usage when using endpoints in the worker #185

russellb opened this issue Apr 9, 2024 · 1 comment

Comments

@russellb
Copy link
Member

russellb commented Apr 9, 2024

When using a model endpoint for precheck and the sdg-svc for generate, we should be able to have multiple concurrent requests to these endpoints to help scale this out. Some thoughts on how to do this ...

  • First we should do some manual / quick script testing of concurrent requests to these endpoints to see if we get any errors when doing 3, 5, 10 (or whatever) at a time. Let's find some number to start with that seems reliable for now.
  • We can't just add multiple goroutines to the same worker. Each worker routine assumes it owns some resources on disk (the taxonomy git clone in particular). There's some choices for this:
    • cleanest -- when running in this mode, we don't need local GPUs. We can move to a pool of cheaper VMs, each running its own worker instance. We can scale that pool of nodes according to the concurrency desired.
    • we can run multiple worker instances on each node, but each needs their own working directory with its own taxonomy repo to work with.
    • Allow multiple go routines in one worker, but like above, each needs its own working directory with a taxonomy repo that it owns.

So, we need some testing, some design decisions, some deployment automation

@russellb
Copy link
Member Author

russellb commented Apr 9, 2024

For the sdg-svc part

as of this AM testing - i feel comfortable that you could put about 10 concurrent requests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant