Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide the non-dismissable streaming/spaces indicator in the timeline on mobile #541

Open
insin opened this issue Apr 5, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@insin
Copy link
Owner

insin commented Apr 5, 2024

With the indicator

Indicator DOM

Screenshot 2024-04-06 at 2 12 32 am

Timeline DOM

The height of the header is adjusted to offset timeline contents to make room for the indicator

Screenshot 2024-04-06 at 2 13 27 am

Without the indicator

Indicator DOM

The [role="grid"] element has [aria-hidden="true"]

Screenshot 2024-04-06 at 2 17 16 am

Timeline DOM

Header height when there's nothing to offset timeline contents to display

Screenshot 2024-04-06 at 2 18 08 am

Implementation

  • While on the timeline. observe the [role="grid"] element for changes to its [aria-hidden] attribute
  • Toggle a Live class on <body> based on the presence of an [aria-hidden] attribute (missing = on, present = off)
  • Use body.Live as a hook to hide the indicator and adjust the timeline header back to its non-indicator height
@insin insin added the enhancement New feature or request label Apr 5, 2024
@insin
Copy link
Owner Author

insin commented May 21, 2024

This is what displays ion desktop when someone is streaming

The Live on X box appears dynamically, popping back into existence every time you change page

Home:

Other pages:

DOM:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant