Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allows to symbolicate the source code and line number for Mac CLI/App crash report on macOS 13+ #44

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Allows to symbolicate the source code and line number for Mac CLI/App crash report on macOS 13+ #44

wants to merge 1 commit into from

Conversation

dreampiggy
Copy link

Feature

This allows to symbolilcate this type of crash report

Thread 0::  Dispatch queue: com.apple.main-thread
0   libsystem_kernel.dylib        	       0x19df63750 __psynch_cvwait + 8
1   libsystem_pthread.dylib       	       0x19dfa0574 _pthread_cond_wait + 1232
2   libc++.1.dylib                	       0x19dec8ef0 std::__1::condition_variable::wait(std::__1::unique_lock<std::__1::mutex>&) + 28
3   bdlli-bind                    	       0x10507c1ac llvm::ThreadPool::wait() + 60
4   bdlli-bind                    	       0x104f48f04 main + 4028
5   dyld                          	       0x19dc47f28 start + 2236

into:

Thread 0::  Dispatch queue: com.apple.main-thread
0   libsystem_kernel.dylib        	       0x19df63750 __psynch_cvwait + 8
1   libsystem_pthread.dylib       	       0x19dfa0574 _pthread_cond_wait + 1232
2   libc++.1.dylib                	       0x19dec8ef0 std::__1::condition_variable::wait(std::__1::unique_lock<std::__1::mutex>&) + 28
3   bdlli-bind                    	       0x10507c1ac llvm::ThreadPool::wait() + 60 (ThreadPool.cpp:147)
4   bdlli-bind                    	       0x104f48f04 main + 4028 (bdlli-bind.cpp:259)
5   dyld                          	       0x19dc47f28 start + 2236

Fixes

Also fix the crash log parsing issue when the symbol already exists (but no source code information)

close #43
close #35

@dreampiggy
Allows to symbolicate the source code and line number for Mac CLI/App…
8b20bb4 
… crash report

Also fix the crash log parsing issue when the symbol already exists (but no source code information)
@dreampiggy
Copy link
Author

@inket

Do you have a macOS 13 environment ? You can simply create a always crashed Mac CLI App and testing this by generated dSYM

Or if not, I can email you my private dSYM and crash log for you (not suitable for open)

@dreampiggy
Copy link
Author

dreampiggy commented Mar 8, 2024 •
edited

Seems Apple use the format for symbolication, replaced the byte offset into source code line (See: https://developer.apple.com/forums/thread/678790)

TODO: So should I symbolicate into this ? Or better idea about the output format ? @inket

Thread 0::  Dispatch queue: com.apple.main-thread
0   libsystem_kernel.dylib        	       0x19df63750 __psynch_cvwait + 8
1   libsystem_pthread.dylib       	       0x19dfa0574 _pthread_cond_wait + 1232
2   libc++.1.dylib                	       0x19dec8ef0 std::__1::condition_variable::wait(std::__1::unique_lock<std::__1::mutex>&) + 28
3   bdlli-bind                    	       0x10507c1ac llvm::ThreadPool::wait() (ThreadPool.cpp:147)
4   bdlli-bind                    	       0x104f48f04 main (bdlli-bind.cpp:259)
5   dyld                          	       0x19dc47f28 start + 2236

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@dreampiggy