Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for multi-hop channels #3988

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Conversation

romac
Copy link
Member

@romac romac commented May 17, 2024

Closes: #3940

* feat: add `--connection-hops` parameter to tx chan-open-init

* Create directory `relayer-types/core/ics33_multihop` for ics33
  definitions

* Define structs `ConnectionHop` and `ConnectionHops`

* Add `connection_hops` field to struct `Channel`

* patch ibc-proto-rs for multihop support

* Add connection hops support to `build_chan_open_init_and_send`

* Enable parsing of multihop `channel_open_init` events

* Add a wrapper struct `ConnectionIds` for Vec<ConnectionId>

* Change `connection_id` type from `ConnectionId` to `ConnectionIds` in
  structs `Attributes`, `OpenInit`, `OpenTry`, `OpenAck`, `OpenConfirm`,
  `CloseInit` and `CloseConfirm`

* Fix clippy warnings

* Apply review suggestions and fix clippy warnings

* Add review suggestions and fix clippy warnings

* Apply suggestions from code review

Co-authored-by: Romain Ruetschi <romain@informal.systems>
Signed-off-by: Joāo Chervinski <22059902+joaotav@users.noreply.github.com>

* Change `--connection-hops` type from `Option<Vec<ConnectionId>>` to
`Option<ConnectionIds>`

* Update guide templates

* Fix failing CI tests

* Add tests for tx chan-open-init CLI

* Apply review suggestions

* Add and update FIXMEs

* Replace "/" with "\" for proper line concatenation

* Update guide templates

---------

Signed-off-by: Joāo Chervinski <22059902+joaotav@users.noreply.github.com>
Co-authored-by: Romain Ruetschi <romain@informal.systems>
@joaotav joaotav self-assigned this May 17, 2024
@joaotav joaotav added the O: multi-hop Related to ICS 033 Multi-Hop Channel label May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O: multi-hop Related to ICS 033 Multi-Hop Channel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multihop PoC
2 participants