Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Header: Primary Buttons on a toolbar in a header not styling correctly #8669

Open
Sovia opened this issue May 2, 2024 · 2 comments
Open
Labels
design Needs input from IDS Design Team team: landmark For Landmark issues type: enhancement ✨ [2] Velocity rating (Fibonacci)

Comments

@Sovia
Copy link
Contributor

Sovia commented May 2, 2024

Describe the bug
The "btn-primary" is not styling a button in a toolbar in a header. For just a btn-primary in a flex toolbar, the buttons appear as filled in blue buttons:
image

However, if this toolbar is inside of a header, then the styling is not added to the buttons:
image

It would be nice if there was primary stylings on the buttons in the header toolbar, and that they would work nicely when the color is personalized on the header as well.

Also, the icon only button icon seems to be a gray icon instead of a white icon.

Steps to reproduce the behavior:

  1. Copy test-toolbar-primary-buttons.zip into the codebase /app/views/components/header
  2. Navigate to /components/header/test-toolbar-primary-buttons.html in the web browser
  3. See error

image

Use Case

  • up to developer but for actions to stand out such as approve or reject

Questions

  • what do with colors (could make it white instead or opposite contrast color
  • fix all primary button types

Expected behavior
There is correct primary button styling on the buttons with btn-primary.

Version

  • ids-enterprise: 4.95.0

Platform

  • Infor Application/Team Name: Landmark UI
  • All devices and platforms
@Sovia Sovia added the team: landmark For Landmark issues label May 2, 2024
@tmcconechy tmcconechy added type: enhancement ✨ [2] Velocity rating (Fibonacci) labels May 2, 2024
@tmcconechy
Copy link
Member

I dont believe we ever supported primary buttons in the toolbar. Especially multiple does not make sense. But will review with design.

@Sovia
Copy link
Contributor Author

Sovia commented May 2, 2024

The multiple was for testing, our use case will only have one per toolbar.

@tmcconechy tmcconechy added the design Needs input from IDS Design Team label May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design Needs input from IDS Design Team team: landmark For Landmark issues type: enhancement ✨ [2] Velocity rating (Fibonacci)
Projects
Status: Groomed
Development

No branches or pull requests

2 participants