Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datagrid: Not spanning the entire width in modals #8658

Open
radovaniljic opened this issue Apr 29, 2024 · 4 comments
Open

Datagrid: Not spanning the entire width in modals #8658

radovaniljic opened this issue Apr 29, 2024 · 4 comments
Assignees
Labels
team: homepages Issues for the homepages team type: bug 🐛 [2] Velocity rating (Fibonacci)

Comments

@radovaniljic
Copy link

Describe the bug
Data grids don't span the entire width in modals

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://main-enterprise.demo.design.infor.com/components/datagrid/test-modal-datagrid-tooltips.html (or any other example where there's a data grid inside a modal)
  2. Open the modal
  3. Open the devtools and edit the modal title (make it long enough so that the modal increases in width), or set a width on one of the elements in the modal.
  4. Notice that the data grid doesn't span the entire modal width.

Expected behavior
The data grid should span the entire modal width.

Version
ids-enterprise: 4.95.0-dev.0

Screenshots
grid_width_modal

Platform

  • Infor Application/Team Name: OS Portal
@tmcconechy tmcconechy added type: bug 🐛 team: homepages Issues for the homepages team [3] Velocity rating (Fibonacci) labels Apr 29, 2024
@tmcconechy
Copy link
Member

Some ideas you could try:

  1. remove any custom widths so its using auto layout: https://github.com/infor-design/enterprise/blob/main/app/views/components/datagrid/test-modal-datagrid-tooltips.html#L31
  2. use percent column widths
  3. Use fixed widths and stretchColumn on one column.

@AAlviar AAlviar added [2] Velocity rating (Fibonacci) and removed [3] Velocity rating (Fibonacci) labels May 8, 2024
@tmcconechy
Copy link
Member

Maybe fixed in 4.95 by https://github.com/infor-design/enterprise/pull/8672/files#diff-cc804a8d1fdaf0bfaf6aa91dbfdf7be69520510ac7133f1dc0b3d916460eae58R1128

We will retry and confirm this sprint

@ericangeles ericangeles self-assigned this May 14, 2024
@ericangeles
Copy link
Contributor

@tmcconechy, looks like it's now fixed.

@ericangeles
Copy link
Contributor

Could you, @n-ace-ancog, re-test this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team: homepages Issues for the homepages team type: bug 🐛 [2] Velocity rating (Fibonacci)
Projects
Status: Ready For QA PR Review
Development

No branches or pull requests

4 participants