Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UX Enhancement: Timeline searching should have an easy way to clear search #1389

Open
markrickert opened this issue Dec 21, 2023 · 0 comments
Open

UX Enhancement: Timeline searching should have an easy way to clear search #1389

markrickert opened this issue Dec 21, 2023 · 0 comments
Assignees
@jonmajorc
Labels
good first issue 🎉 Something easier for newcomers! request 👍 I would like this to be a thing.

Comments

@markrickert
Copy link
Member

I noticed that when you do a timeline search if you click the search button to hide the search bar, the results stay filtered. The only way clear the search is to backspace the search results out of the search bar.

We should add an X or Clear button to make clearing timeline search results easier.
@markrickert markrickert added request 👍 I would like this to be a thing. good first issue 🎉 Something easier for newcomers! labels Dec 21, 2023
@jonmajorc jonmajorc mentioned this issue Jan 5, 2024
Merged
jonmajorc added a commit that referenced this issue Jan 9, 2024
@jonmajorc
#1389 Add clear search button (#1394)
e7e91a4 
Implements feature improvement #1389



https://github.com/infinitered/reactotron/assets/7799266/a6b0d72c-b519-4501-bd04-3698738014a2

I made a change in `lib/reactotron-core-ui`, so test you'll have to
first build that package 😃
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jonmajorc jonmajorc

Labels
good first issue 🎉 Something easier for newcomers! request 👍 I would like this to be a thing.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@markrickert @jonmajorc