Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in the wiki #6

Open
spetrac-nicos-ag opened this issue Dec 2, 2021 · 2 comments
Open

Typo in the wiki #6

spetrac-nicos-ag opened this issue Dec 2, 2021 · 2 comments
Assignees

Comments

@spetrac-nicos-ag
Copy link

There is a minor typo in the wiki, but i stumbled uppon it when implementing the idscp2 fsm, because some states where a bit off.
https://github.com/industrial-data-space/idscp2-java/wiki/IDSCP2-Core

In the description of the states ESTABLISHED and WAIT_FOR_ACK there are the events SC_DAT_EXPIRED and SC_RE_RA.
As of the event description those events are probably meant to be SC_IDSCP_DAT_EXPIRED and SC_IDSCP_RE_RA.

This has no priority as the correct events are pretty obvious, but I wanted to report the typos anyway to help prevent copy-paste errors like mine.

@milux
Copy link
Contributor

milux commented Jan 20, 2022

Thanks, but I didn't get your idea yet. Could you please elaborate?
How does the suggested spelling change provide more clarity? What did you misunderstand from the original event names?
We are speaking about the FSM of the IDSCP2 protocol, so everything is somewhat related to IDSCP2, right?

@oxisto
Copy link
Contributor

oxisto commented Jan 21, 2022

Thanks, but I didn't get your idea yet. Could you please elaborate?
How does the suggested spelling change provide more clarity? What did you misunderstand from the original event names?
We are speaking about the FSM of the IDSCP2 protocol, so everything is somewhat related to IDSCP2, right?

In the event list and in most states its called SC_IDSCP_DAT_EXPIRED, but in the ESTABLISHED and WAIT_FOR_ACK state its called SC_DAT_EXPIRED, same for SC_RE_RA. It should always be called SC_IDSCP_DAT_EXPIRED I guess

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants