Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Container crashed" may be interpreted as nuisance failure #1026

Open
inducer opened this issue Sep 18, 2023 · 0 comments
Open

"Container crashed" may be interpreted as nuisance failure #1026

inducer opened this issue Sep 18, 2023 · 0 comments

Comments

@inducer
Copy link
Owner

inducer commented Sep 18, 2023

Setting the recursion limit to (say) 10k and then overflowing the stack leads the container to crash. The result is a RemoteDisconnected error, which is currently being treated as a "nuisance failure", with inappropriate student messaging:

relate/course/page/code.py

Lines 370 to 398 in 35cd621

def is_nuisance_failure(result):
if result["result"] != "uncaught_error":
return False
if "traceback" in result:
if "BadStatusLine" in result["traceback"]:
# Occasionally, we fail to send a POST to the container, even after
# the inital ping GET succeeded, for (for now) mysterious reasons.
# Just try again.
return True
if "bind: address already in use" in result["traceback"]:
# https://github.com/docker/docker/issues/8714
return True
if ("requests.packages.urllib3.exceptions.NewConnectionError"
in result["traceback"]):
return True
if "http.client.RemoteDisconnected" in result["traceback"]:
return True
if "[Errno 113] No route to host" in result["traceback"]:
return True
return False

See also #1025.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant