Skip to content
This repository has been archived by the owner on Aug 16, 2023. It is now read-only.

Use conditional requests to avoid rate limiting problems #44

Open
danisyellis opened this issue Jun 8, 2020 · 9 comments
Open

Use conditional requests to avoid rate limiting problems #44

danisyellis opened this issue Jun 8, 2020 · 9 comments
Assignees
Labels
good first issue Good for newcomers Hacktoberfest up-for-grabs This issue is ready to be worked on, and unassigned

Comments

@danisyellis
Copy link
Collaborator

See this link for more info conditional requests: https://developer.github.com/v3/#conditional-requests
We could use either ETags or the If-Modified-Since header.

Making a conditional request and receiving a 304 response does not count against our rate limit, so it could help any rate limiting issues.
We (at Indeed) haven't seen a huge problem with this, but a larger org almost certainly would.

@rajaSahil
Copy link

rajaSahil commented Oct 2, 2020

Hi, @danisyellis I would like to take up this task as my first contribution. It would be great to learn something out of it

@danisyellis
Copy link
Collaborator Author

Hi @rajaSahil That would be fantastic.
let me know if you have any questions.

@danisyellis
Copy link
Collaborator Author

Hi @rajaSahil I just wanted to let you know that I'm doing virtual "office hours" tomorrow (maybe today when you read this) October 14th at 4pm PST https://organize.mlh.io/participants/events/5666-virtual-starfish-office-hours. And then again on October 26th from 2-3pm PST. https://organize.mlh.io/participants/events/5668-virtual-starfish-office-hours
If you have any questions about this ticket, you're welcome to pop in then and I can try to answer them or work through it with you.

@rajaSahil
Copy link

Thanks, @danisyellis I will try to join the virtual office, although it will be early morning here(4:30 am).

@danisyellis
Copy link
Collaborator Author

Oof, that's really early! We can also set up some other time that works better for each of our timezones!

@rajaSahil
Copy link

Yes, that would be really helpful.

@danisyellis
Copy link
Collaborator Author

Hi @rajaSahil are you still interested in working on this? If not, I'll unassign you.

@danisyellis danisyellis added the up-for-grabs This issue is ready to be worked on, and unassigned label Jan 8, 2021
@shehriyarnadeem
Copy link

@danisyellis Can I work on this task? I would be the first one in my open source journey. So please assign it to me if possible.

@kevindigo
Copy link
Collaborator

Hi @shehriyarnadeem. I will assign it to you. The primary maintainer (Dani) is unavailable right now, but I can try to help with any questions you might have. In particular, I encourage you to outline what solution you are going to try, to ensure that it will meet the requirements.

When I tried the earlier docs link, it didn't seem to take me to a relevant section. I found this, which might be helpful, although I only took a quick glance at it: https://docs.github.com/en/rest/overview/resources-in-the-rest-api#conditional-requests

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
good first issue Good for newcomers Hacktoberfest up-for-grabs This issue is ready to be worked on, and unassigned
Projects
None yet
Development

No branches or pull requests

4 participants