Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jakarta compatibility on generated class AbstractGroupsManager #163

Open
ykevinc opened this issue Apr 16, 2024 · 1 comment
Open

jakarta compatibility on generated class AbstractGroupsManager #163

ykevinc opened this issue Apr 16, 2024 · 1 comment

Comments

@ykevinc
Copy link

ykevinc commented Apr 16, 2024

Hi,

Thanks for open sourcing this AB testing library.

With

import jakarta.servlet.http.HttpServletRequest;
import jakarta.servlet.http.HttpServletResponse;

superseded

import javax.servlet.http.HttpServletRequest;
import javax.servlet.http.HttpServletResponse;

https://github.com/spring-projects/spring-boot/wiki/Spring-Boot-3.0.0-M1-Release-Notes
https://stackoverflow.com/questions/71179660/spring-boot-3-jakarta-and-javax

Will there be any plan on switching the import over to jakarta?

Thank you.

@SwapnilUgalmugale
Copy link

Yes you should import 'jakarta' over to 'javax'.While your Spring Boot application may currently function properly with both 'javax' and 'jakarta' libraries due to Spring Boot's backward compatibility, it's crucial for future compatibility with Jakarta EE 9 and Jakarta-compatible servers like Tomcat 10 its is recommended by spring boot 3 release notes to use imports from 'javax' to 'jakarta'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants