Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize versioning actions by sending via request #371

Closed
longquanzheng opened this issue Feb 22, 2024 · 3 comments
Closed

Optimize versioning actions by sending via request #371

longquanzheng opened this issue Feb 22, 2024 · 3 comments

Comments

@longquanzheng
Copy link
Contributor

longquanzheng commented Feb 22, 2024 •
edited

Optional to use for api service config

#368

#370

TODO:

iwf/service/interpreter/globalVersioner.go

Line 21 in 5debdce

sas, err := workflowProvider.GetSearchAttributes(ctx, []iwfidl.SearchAttributeKeyAndType{
has a bug for continueAsNew. The continuedAsNew run will inherite the SAs from previous, but they may have call getVersion and upsertSA already
@longquanzheng
Copy link
Contributor Author

longquanzheng commented Feb 29, 2024 •
edited

Add checking if the optimization version is supported

@longquanzheng
Copy link
Contributor Author

longquanzheng commented Mar 16, 2024 •
edited

Need to add logic to check supported optimization version like global version

also bump a global version for this

@longquanzheng
Copy link
Contributor Author

done. #382

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@longquanzheng