Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide Sub exceptions of ClientSideException to be more friendly to catch #203

Open
longquanzheng opened this issue Jul 31, 2023 · 0 comments
Open

Provide Sub exceptions of ClientSideException to be more friendly to catch #203

longquanzheng opened this issue Jul 31, 2023 · 0 comments

Comments

@longquanzheng
Copy link
Contributor

longquanzheng commented Jul 31, 2023 •
edited

WORKFLOW_ALREADY_STARTED_SUB_STATUS ==> WorkflowAlreadyStartedException

WORKFLOW_NOT_EXISTS_SUB_STATUS ==> WorkflowNotExistsOrOpenException (for write operation like signal/RPC) . This is a bad name that we inherit from Cadence/Temporal. The temporal SDK use not_found for not able to signal(even the workflow does exist, but it’s just not open to signal)

LONG_POLL_TIME_OUT_SUB_STATUS ==> LongPollTimeoutException

This should be backward compatible change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@longquanzheng