Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide overridden Client API without workflowRunId required #183

Closed
longquanzheng opened this issue Jul 11, 2023 · 4 comments
Closed

Provide overridden Client API without workflowRunId required #183

longquanzheng opened this issue Jul 11, 2023 · 4 comments
Assignees
Labels

Comments

@longquanzheng
Copy link
Contributor

Even putting an empty string as workflowRunId is unnecessary

@zklgame zklgame self-assigned this Jul 14, 2023
@zklgame
Copy link
Contributor

zklgame commented Jul 14, 2023

Quick question: is there any Client public API must have the runId?

@longquanzheng
Copy link
Contributor Author

Quick question: is there any Client public API must have the runId?

Technically, all the api may need it if want to call the api on the previous one with the same workflowID.

For example, read only RPC can still be called on older run to get some data.

However, the runID could be tricky to get because of auto continue as new , unless

  • user use “searchWorkflow” api to get the last one of the “continueAsNew chain” before calling it
  • Or disabling the auto continue as new (override the threshold to zero)

@longquanzheng
Copy link
Contributor Author

user use “searchWorkflow” api to get the last one of the “continueAsNew chain” before calling it

I just opened a ticket indeedeng/iwf#306 to have a separate API for this

@zklgame
Copy link
Contributor

zklgame commented Jul 15, 2023

in #185

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants