Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API improvements/breaking changes: NewXyzCommand should not need commandID #47

Open
longquanzheng opened this issue Feb 8, 2023 · 1 comment

Comments

@longquanzheng
Copy link
Contributor

This includes:

  • NewTimerCommand
  • NewSignalCommand
  • NewInterstateChannelCommand

Most of the time people don't need to use commandId.

We can create new APIs for using commandID:

  • NewTimerCommandWithId
  • NewSignalCommandWithId
  • NewInterstateChannelCommandWithId
@longquanzheng
Copy link
Contributor Author

Alternatively make NewTimerCommandByDuration NewSignalCommandByChannel etc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant