Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propose gen_server et all "no-timeout" functions as no_common_caveats? #320

Open
paulo-ferraz-oliveira opened this issue Aug 27, 2023 · 0 comments
Labels

Comments

@paulo-ferraz-oliveira
Copy link
Collaborator

Name

None yet.

Brief Description

Should we propose some of the base functions (that have a timeout counterpart) to be added to the list of no_common_caveats functions? We could even call this "use-explicit-timeout".

There's a few considerations here:

  • the list of functions would eventually have to be updated - and I prefer not to have to revisit rules, most of the time
  • it's possible that the interface breaks in the future (it is already possible today, of course) and this is also extra-maintenance, because now the suggestion is OTP-version specific

This raised, though, another interesting thought, to me.

Should elvis_core consider rules to be grouped by severity, such as info, warning, all, etc.? There's already a proposal to categorize them by "type".

Reasoning

Check this out: https://erlangforums.com/t/thoughts-on-the-default-timeout-for-gen-server-call/2812

Refactoring Proposal

"Update your code."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant