New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

apns crashes with {case_clause,{error,{closed,"The connection was lost."}} #254

Open

ghost opened this issue Aug 2, 2022 · 0 comments

ghost commented Aug 2, 2022 •

edited by ghost

Hi,

Function apns_connection:push/4
https://github.com/inaka/apns4erl/blob/master/src/apns_connection.erl/#L476-L483
is missing several values returned by gun:await/3.

This will cause the function crashes, in my case, when gun returns {error,{closed,"The connection was lost."}}.

Can someone please fix this? at least I think it would be useful to inform clients about connection errors, beside timeout.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment