Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transpile #include as include!() #1053

Open
HKalbasi opened this issue Dec 17, 2023 · 4 comments
Open

Transpile #include as include!() #1053

HKalbasi opened this issue Dec 17, 2023 · 4 comments

Comments

@HKalbasi
Copy link
Contributor

Currently, each generated file contains a copy of each header file it includes, so to make a change/refactor you will need to change multiple places, making changes harder than necessary. By transpiling C #includes to Rust include!, it will become much easier to refactor without losing the C semantics (which will probably happen by using mod and similars).
@kkysen
Copy link
Contributor

kkysen commented Dec 17, 2023

This is a good idea.

@pitaj
Copy link

pitaj commented Mar 4, 2024

Duplicate of #1050 ?

@kkysen
Copy link
Contributor

kkysen commented Mar 4, 2024

Duplicate of #1050 ?

This is a bit different I think.

@pitaj
Copy link

pitaj commented Mar 4, 2024

They essentially describe the same idea, the only difference is that this one suggests using include!() to implement it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pitaj @kkysen @HKalbasi