extractUserData only works with usernames

[spaceemotion]

My app uses JWT to authenticate users, which only contain a user ID, and not a user name.

The current requirement for getting extractUserData to work (based on the types at least) is to always provide a username though:

fastify-sentry/utils.d.ts

Line 29 in 598a4dc

username: string,

Is there a way to make them all optional? Not all my requests have an authenticated user (some are public routes) so being able to return 'nothing' would also come in quite handy.

[dnlup]

Hi @spaceemotion , thank you for reporting this. username should definitely be optional, that's how it's handled too (

fastify-sentry/utils.js

Line 77 in 598a4dc

if (key in user) {

). would you like to open a PR to fix that type?

[spaceemotion]

@dnlup would that make all keys optional then? some people might only have the ID, some only the username...

[dnlup]

@dnlup would that make all keys optional then? some people might only have the ID, some only the username...

@spaceemotion Yes, all the keys should be optional