Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embedded color profiles not applied #100

Open
automata opened this issue Dec 9, 2016 · 5 comments
Open

Embedded color profiles not applied #100

automata opened this issue Dec 9, 2016 · 5 comments
Labels

Comments

@jonnor
Copy link
Member

jonnor commented Dec 9, 2016

@automata where/how do they differ on your device? Can you screenshot side-by-side?

On my Android phone I am unable to discern any difference. Which may mean this is about color management (or rather, lack thereof).

@forresto
Copy link

forresto commented Dec 9, 2016

Smells like color space issue:

Original:

WARNING: Embedded color profile: “(unrecognized embedded color profile 'ProPhoto RGB')”

http://regex.info/exif.cgi?imgurl=https%3A%2F%2Fthe-grid-user-content.s3-us-west-2.amazonaws.com%2Fbaa20170-30cb-4b91-b6e4-e2fb23f85201.jpg

imgflo passthrough:

WARNING: No color-space metadata and no embedded color profile: Windows and Mac web browsers treat colors randomly.

http://regex.info/exif.cgi?dummy=on&imgurl=https%3A%2F%2Fs3-us-west-2.amazonaws.com%2Fthe-grid-img%2Fp%2F5441a8fdc92d4c7462f0dec49eeea876a23086a9.jpg

@forresto
Copy link

forresto commented Dec 9, 2016

(original left passthrough right)
original left passthrough right

@forresto
Copy link

forresto commented Dec 9, 2016

Interesting... Android original looks like Mac passthrough.

@jonnor can passthrough pass through the color space metadata? There will still be discrepancies across systems, but at least on the same device it will be the same.

@jonnor
Copy link
Member

jonnor commented Dec 9, 2016

The output image is a new image, and there is no facilities in GEGL atm for tracking colorspace through the processing pipeline. But preprocessor to extract color profile and then reinserting into output image would be possible.
It would however leave browsers without color management support (like Chrome on Android) with bland colors.
Alternative is to convert to sRGB when reading the input. That would make it look the same on all browsers. However on high-end displays where CM is supported the images may be duller than possible, because the smaller gamut of sRGB clips possible outputs.

@jonnor jonnor changed the title Different colors on passthrough graph Embedded color profiles not applied May 3, 2018
@jonnor jonnor added the bug label May 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants