Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ImgBot messing up Image Saturation #856

Open
daggy1234 opened this issue Mar 2, 2021 · 8 comments
Open

ImgBot messing up Image Saturation #856

daggy1234 opened this issue Mar 2, 2021 · 8 comments
Labels

Comments

@daggy1234
Copy link

if you compare the before and after of images in this repo, while imgbot did compress the images, there was a weird color shift.

https://github.com/Daggy1234/discord.py/tree/image-fixes

Look at the before and after

daggy1234/discord.py#3

The images have become more saturated.

@daggy1234 daggy1234 changed the title ImgBot messing up Image colors ImgBot messing up Image Saturation Mar 2, 2021
@daggy1234
Copy link
Author

daggy1234 commented Mar 2, 2021

A few Images of before and after

a
b

@daggy1234
Copy link
Author

Am I doing something wrong.....

@dabutvin dabutvin added the bug label Mar 10, 2021
@dabutvin
Copy link
Contributor

thanks for reporting! I don't think you're doing anything wrong here.
This needs more investigation

@IlanCosman
Copy link

Probably related: #815

@SeriousBusiness100
Copy link

Encountered color diff myself: fastlane/metadata/android/en-US/images/sevenInchScreenshots/6.png

@cooljeanius
Copy link

I think this might have been what led to ForestDragon-wesnoth/Spartan#10 being rejected

@cooljeanius
Copy link

@GrigoreMihai could you take a look at this please?

@cooljeanius
Copy link

thanks for reporting! I don't think you're doing anything wrong here. This needs more investigation

@dabutvin did you ever get a chance to investigate more?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants