Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uses wrong units. #1068

Open
K0-RR opened this issue Nov 22, 2021 · 3 comments · May be fixed by #1143
Open

Uses wrong units. #1068

K0-RR opened this issue Nov 22, 2021 · 3 comments · May be fixed by #1143
Labels
pinned prevents stalebot from marking an issue as stale

Comments

@K0-RR
Copy link

K0-RR commented Nov 22, 2021

Example Imgbot PR - K0-RR/BasicNetherOres#2
Inside the details section, columns before and after use kilobits (kb) whereas the size value is in fact in kilobytes (kB).
Also, theoretically, the unit in use should be Kibibyte, not Kilobyte.
@MichaIng
Copy link

KiB, MiB etc would be precise, so multi-byte units notation.

@GrigoreMihai GrigoreMihai added the pinned prevents stalebot from marking an issue as stale label Dec 8, 2021
@lnsandnkth
Copy link

Hello there, I would like to add this functionality. Could someone add me as participant?

@lnsandnkth lnsandnkth mentioned this issue Apr 11, 2022
Merged
@MichaIng
Copy link

That would be great. I suggest you fork the project, apply the changes to your fork, then open a pull request with your changes here.

I'm not sure whether contributors are added to the orga or as formal collaborators here at all, but definitely not because of a post in a random open issue and more likely after a successful contribution via pull request 🙂.

@lnsandn01 lnsandn01 linked a pull request Apr 13, 2022 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
pinned prevents stalebot from marking an issue as stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

converting sizeBefore and sizeAfter to correct binary multi-byte units lnsandn01/Imgbot
4 participants
@MichaIng @GrigoreMihai @K0-RR @lnsandnkth