Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Support conversion to webp format #1049

Open
aditya-leap opened this issue Nov 1, 2021 · 6 comments
Open

Feature Request: Support conversion to webp format #1049

aditya-leap opened this issue Nov 1, 2021 · 6 comments
Labels
enhancement pinned prevents stalebot from marking an issue as stale

Comments

@aditya-leap
Copy link

Request for new feature: Please enable conversion to WebP format for images, such that all uploaded images (jpg,png) are automatically converted to WebP format

@GrigoreMihai
Copy link
Contributor

This is a really good suggestion, I think this will be implemented as another setting in .imgbotconfig would you also find it useful as a global toggle here: https://imgbot.net so it will apply to all repositories ?

@GrigoreMihai GrigoreMihai added pinned prevents stalebot from marking an issue as stale enhancement labels Nov 1, 2021
@MichaIng
Copy link

MichaIng commented Nov 24, 2021

I'd like it as global toggle as well, respectively IMHO it makes sense to have it globally enabled OOTB as there is no reason to handle webp any different than JPEG or PNG. But this is more a minor convenience question: Having support at all, via .imgbotconfig or any other way, would be great 🙂.

EDIT: Globally enabled by default was meant for webp optimisation, but conversion shouldn't be enabled by default of course.

@LukasGutenberg
Copy link

Hello, me and a lab partner are looking to implement this feature as part of a course in devops at KTH. Any tips before we start?

@DaveSkender
Copy link

Here’s some basic info on webp: https://developers.google.com/speed/webp

@LukasGutenberg
Copy link

Thanks, you can expect a PR sometime next week or early the following one.

@Autonymic
Copy link

Autonymic commented May 11, 2022

We have problems running it locally on our computers. Line 16 in CompressImagesFunction.csproj

<Copy SourceFiles="@(NativeBinary)" DestinationFiles="@(NativeBinary->'$(TargetDir)bin/%(Filename)%(Extension)')" />

We get errors that claim it can't copy those files as they cannot be found. Do we have to download these or how do we resolve this?

EDIT: For running it on a local machine those lines aren't needed so we removed them to get it running. It's just we have difficulties testing the functions as the documentation for how to run things is lacking.

EDIT2: We have decided to drop this, as we've run out of time. If anyone else is willing to tackle this issue, go ahead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement pinned prevents stalebot from marking an issue as stale
Projects
None yet
Development

No branches or pull requests

6 participants