Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draggable HTML attribute is set to "true" when it equals "false" as a string #857

Open
mpeg opened this issue Jul 31, 2023 · 1 comment
Open
Labels

Comments

@mpeg
Copy link
Contributor

mpeg commented Jul 31, 2023

Description

If I add the draggable attribute to an element rendered by imba:

tag my-tag
    <self>
        <p draggable="false">

It renders into <p draggable="true">

If instead I pass in a boolean value like <p draggable=false> it has the correct behavior of setting draggable to "false" – in this case it's very confusing as draggable is a native html attribute so you would expect the "false" string to be passed through directly.

Reproduction

No response

System Environment

No response

@mpeg mpeg added the bug label Jul 31, 2023
@haikyuu
Copy link
Collaborator

haikyuu commented Jul 31, 2023

for props you want to be treated as html attributes, you want to use <p html:draggable="false">
See https://scrimba.com/scrim/c8pLPKAV for more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants