Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search results should show icons to help disambiguate #284

Open
ctrueden opened this issue Jul 26, 2023 · 2 comments · May be fixed by #290
Open

Search results should show icons to help disambiguate #284

ctrueden opened this issue Jul 26, 2023 · 2 comments · May be fixed by #290
Assignees
@gselzer
Labels
enhancement New feature or request
Projects
napari-imagej plugin
Milestone
0.2.0

Comments

@ctrueden
Copy link
Member

In Fiji, the search results show icons for commands, and in particular all ImageJ 1.x commands use the ImageJ 1.x microscope icon. SciJava commands are able to declare their desired icon, and if they do not due so a stupid puzzle piece icon is used (tangentially: I propose we change all ImageJ2 commands to the IJ2 logo, and all SciJava-layer commands in scijava-plugins-commands to the SciJava logo by default).

In napari-imagej, no icons are shown, and you cannot tell at a glance whether a command is an ImageJ or SciJava/ImageJ2 command. It would be great if napari-imagej could load and display the icons somehow. However, if calling Java to load them as resources out of the JAR files is too expensive time-wise, that would be understandable... but we could at least hardcode in the IJ vs IJ2 icons for each type of command, no?
@ctrueden ctrueden mentioned this issue Jul 26, 2023
Open
@gselzer
Copy link
Collaborator

gselzer commented Jul 26, 2023

This may be of use: https://doc.qt.io/qt-6/qtreewidgetitem.html#setIcon

@gselzer gselzer self-assigned this Jul 26, 2023
@gselzer gselzer added the enhancement New feature or request label Jul 26, 2023
@gselzer gselzer added this to the 0.2.0 milestone Jul 26, 2023
@gselzer
Copy link
Collaborator

gselzer commented Aug 14, 2023

I started working on this, but I quickly realized that adding icons to a QTreeWidget would be tricky, and figured that switching our search results to a Qt model/view approach would probably be the correct fix.

I started working on this, but I don't have a good enough understanding of the data structure yet...

@gselzer gselzer linked a pull request Aug 16, 2023 that will close this issue
Switch SearchResult display to model/view paradigm #290
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gselzer gselzer

Labels
enhancement New feature or request
Projects
napari-imagej plugin
Awaiting triage
Milestone
0.2.0
Development

Successfully merging a pull request may close this issue.

Switch SearchResult display to model/view paradigm imagej/napari-imagej
2 participants
@ctrueden @gselzer