Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Numeric type inputs have undesirable bounds #276

Open
ctrueden opened this issue Jul 26, 2023 · 1 comment
Open

Numeric type inputs have undesirable bounds #276

ctrueden opened this issue Jul 26, 2023 · 1 comment
Assignees
Labels
bug Something isn't working
Milestone

Comments

@ctrueden
Copy link
Member

Even for numbers that are not supposed to be bounded, they are hardcoded to [0, 1000) as min/max bounds. For example, the bundled Example_Script.js has many numeric inputs of various sizes, but most of them have no explicit min/max declarations, and so should not be bounded. But e.g. the oLong, which is a 64-bit signed long type, is still bounded at [0, 1000). If this is an issue with how we are using magic_gui, we should address it, or if it is a fundamental magic_gui limitation/bug, we should file a PR upstream.

@gselzer
Copy link
Collaborator

gselzer commented Jul 26, 2023

Yeah, that's tricky, as we are definitely bounded by magicgui/qt here - that's the default min/max for integer types, iirc.

We could probably start with a function like this one to cover Number/primitive minima/maxima

@gselzer gselzer self-assigned this Jul 26, 2023
@gselzer gselzer added the bug Something isn't working label Jul 26, 2023
@gselzer gselzer added this to the 0.2.0 milestone Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
napari-imagej plugin
Awaiting triage
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants