Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

preventCurveOverShooting sounds like mitigation rather than solution #1648

Open
chris-rutkowski opened this issue May 1, 2024 · 1 comment

Comments

@chris-rutkowski
Copy link

chris-rutkowski commented May 1, 2024

Hey, amazing plugin, please don't get me wrong with this issue.

There are a lot of issues that include the keyword preventCurveOverShooting. It is always suggested to the problem that can be seen on the picture (taken from one of the issues):

Screenshot 2024-05-01 at 9 06 43 PM

But I don't think it is a solution. While it's nice to have a control over "roundness", there shouldn't be preventCurveOverShooting+preventCurveOvershootingThreshold as there shouldn't be any over shooting in the first place. Chart shouldn't display data that doesn't exist.

Those bumps are buggy and glitchy. aboveBarData and belowBarData doesn't colour them when they are rendered beyond bounds. The issue #25 has been closed, despite glitch reported there by @jamesblasco - line has inconsistent thickness when those prevent... are toggled on.

Once again, amazing work, love your plugin, but would kindly appreciate reconsidering this implementation. We just want round lines, not zigzags :)

@TobiasRump
Copy link

Yeah it would be a really good idea, to have the preventCurveOverShooting = true as default.

Here is again a user from today, who is confused

#1649

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants