Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multithreaded CinemaDNG export #270

Open
BenjaminNavarro opened this issue Jun 22, 2023 · 4 comments
Open

Multithreaded CinemaDNG export #270

BenjaminNavarro opened this issue Jun 22, 2023 · 4 comments
Labels

Comments

@BenjaminNavarro
Copy link

I just started using MLV-App and I have an hour long video to export in CinemaDNG which takes forever. So I looked at the CPU usage and saw that only one core was used. The disk usage seems to be around 50MB/s so I'm pretty confident that parallelizing the export would bring a significant speedup, probably around 8x for my hardware. And since it's converting still frames to individual files it should be pretty easy to do.

Is there any reason why the export is single threaded? I haven't looked at the code yet but I'm willing to try to make a PR for this

@masc4ii
Copy link
Collaborator

masc4ii commented Jun 22, 2023

Yes, there is a reason: the lossless de-/compression works just single threaded. If you find another solution, feel free to make a PR.
If you use MLVFS, you already have that multithreaded, because this app can handle multiple clips at once, which is not possible in MLVApp.

@masc4ii masc4ii added the Info label Aug 1, 2023
@Jip-Hop
Copy link

Jip-Hop commented Apr 17, 2024

Yes, there is a reason: the lossless de-/compression works just single threaded.

On a MacBook Pro 14-inch, nov. 2023 M3 Pro 18 GB I see MLV App is able to utilize all available CPU resources when exporting CinemaDNG (Lossless).

IMG_9290
IMG_9291
IMG_9292

I've used the M04-1815.MLV sample from https://drive.google.com/drive/folders/1rE6AHE-up7u_5mnWnLjW7h8g3dLopiUG for reference.

So I looked at the CPU usage and saw that only one core was used.

Is there an explanation why my test seems to show more than 1 core being used during export?

@masc4ii
Copy link
Collaborator

masc4ii commented Apr 17, 2024

The DNG export itself is still single threaded. But for being able to export, a MLV must be loaded, RAW Corrections have to be done, (etc. etc.). And this is multithreaded.

@Jip-Hop
Copy link

Jip-Hop commented Apr 18, 2024

The DNG export itself is still single threaded

In my case it appears not to be a bottleneck since the export process can max out the CPU resources of the MacBook regardless...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants