Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vertical stripes not working on 5D3 clips sometimes #202

Open
ilia3101 opened this issue Feb 12, 2020 · 6 comments
Open

Vertical stripes not working on 5D3 clips sometimes #202

ilia3101 opened this issue Feb 12, 2020 · 6 comments

Comments

@ilia3101
Copy link
Owner

Stripes showing up in underexposed clips mostly... sample attached.

SHORT.MLV.zip

@masc4ii
Copy link
Collaborator

masc4ii commented Feb 12, 2020

Hm... in the sky it works perfectly (see at sharpen = 100), but the darks are bad.

@ilia3101
Copy link
Owner Author

Maybe it is some different kind of stripes. I will investigate more.

@ilia3101
Copy link
Owner Author

ilia3101 commented Feb 13, 2020

I compared and found that, this shadow stripe issue only happens in crop_rec 12 bit.

I'll post comparison later

@masc4ii masc4ii changed the title Vertical stripes not working on 5D3 clips sopmetimes Vertical stripes not working on 5D3 clips sometimes Mar 3, 2020
@ilia3101
Copy link
Owner Author

I think this happens in conpressed 12/10 bit because stripe algorithm is searching for stripes in highlight range of 14 bit, as compressed 12/10 bit is in a 14 bit container. The way to fix this would be to have stripe algorithm take white level of footage in to consideration I think.

@bouncyball-git
Copy link
Collaborator

bouncyball-git commented Mar 16, 2020

It is taken in consideration, but it seems that's not enough.

static void detect_vertical_stripes_coeffs(stripes_correction * correction, uint16_t * image_data, int32_t black_level, int32_t white_level, int32_t raw_info_frame_size, uint16_t width, uint16_t height)

@ilia3101
Copy link
Owner Author

Veery strange :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants