Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When viewing a layout from a permlink the save button should be enabled and the layout considered "dirty" #343

Open
guest20 opened this issue Feb 26, 2024 · 0 comments

Comments

@guest20
Copy link

guest20 commented Feb 26, 2024

As a user of kle I want to be able to save a linked keybaord layout to my github gists without editing them first so that I can stop wiggling a random key left/right to mark the layout as dirty

Current Behaviour:

  1. Someone pastes a permalink to layout (starting wiht @ in it or not) on chat
  2. I click the link
  3. I reply to their comment with "nice man, looks sick"
  4. The top right corner of the page looks like this:
Screen Shot 2024-02-26 at 16 24 34

At this point the keyboard data is only in my browser history, but not saved in my gists.

If I want to save this layout as a gist I have to make it "dirty" first. I usually do this by clicking a random key and moving it left, then right... (It has to be an operation I can easy reverse because undoing an operation will un-dirty it).

This doesn't always work out nicely for keys that are rotated. (like in the Atreus layout)

Desired Behaviour:

I think the Save button should not be disabled when the layout is loaded from a url, so that I can save the layout. This might be difficult if the layout has the same name as one I already have, it's hard to say.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant