Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix @username #171

Closed
wants to merge 1 commit into from
Closed

fix @username #171

wants to merge 1 commit into from

Conversation

successgo
Copy link
Contributor

fix #169

forecho
forecho reviewed Apr 5, 2019
View reviewed changes
common/services/PostService.php
@@ -100,7 +100,7 @@ public static function contentReplaceAtUser($content, $model)

public static function parseUsername($content)
{
preg_match_all('/@(\S{4,255}) /', $content, $matches);
preg_match_all('/@(\S{4,255})\b/', $content, $matches);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

好像并不行吧

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我测试过的，可以的。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

当已经替换过的用户名，再次编辑保存时，就会有问题了，我现在想到这种场景会有问题。让我再想想办法

@successgo successgo closed this Apr 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@forecho forecho forecho left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

@username 功能失效
2 participants
@successgo @forecho