Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

group by haplotype? #1509

Open
kevfengler227 opened this issue Apr 3, 2024 · 4 comments
Open

group by haplotype? #1509

kevfengler227 opened this issue Apr 3, 2024 · 4 comments
Milestone

Comments

@kevfengler227
Copy link

I recall a very useful feature in previous versions for grouping by haplotype based on the number of specified groups. Is that feature still available I am not seeing it "Group By" options anymore?

Thanks,
KF

@ASLeonard
Copy link

There is a groupby "phase" option or by tag (typically HP or PS) option, which is what I used for haplotype-binned alignments

@kevfengler227
Copy link
Author

So I am talking about a "Group By" function that would actually compute the clustering for un-binned alignments. Given un-binned alignments you could specify how many haplotype groups you wanted to create and it would do the clustering. Sort of like the group by base, or insert, but for all variations. It used to be there.

@jrobinso
Copy link
Contributor

jrobinso commented Apr 7, 2024

@kevfengler227 Sorry for the delay. I was not aware anyone used that, it was experimental and never worked to my satisfaction. I will look into restoring it, there was some refactoring done for base modifications and I think it was probably dropped then.

@jrobinso jrobinso modified the milestones: 3.0.0, 2.17.5 Apr 7, 2024
@kevfengler227
Copy link
Author

Thanks Jim. I am glad to hear it. Otherwise I was worried I was having a Mandela Effect moment. I thought it worked pretty well. It is very useful for alignment based applications for polyploids or pangenomes, so I would be happy if you could bring it back.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants