Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Matchers - Add matchers for all validators #211

Open
Mth0158 opened this issue Nov 7, 2023 · 7 comments
Open

Matchers - Add matchers for all validators #211

Mth0158 opened this issue Nov 7, 2023 · 7 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@Mth0158
Copy link
Collaborator

Mth0158 commented Nov 7, 2023

Some validators do not have their matcher, it should be implemented.

List of missing matchers:

  • limit
  • processable_image
@Mth0158 Mth0158 added the good first issue Good for newcomers label Nov 7, 2023
@chahmedejaz
Copy link

Hey @Mth0158 - I'd love to work on this issue, can you please assign it to me? Thanks.

@Mth0158
Copy link
Collaborator Author

Mth0158 commented Nov 8, 2023

Hi @chahmedejaz! Thanks for your message, I have just assigned the ticket to you.
Just to let you know, it's better if you wait a few days to start this one, a lot of things will be refactored on the matcher part once #206 is merged :)

@Mth0158 Mth0158 assigned Mth0158 and chahmedejaz and unassigned Mth0158 Nov 8, 2023
@chahmedejaz
Copy link

Hi @chahmedejaz! Thanks for your message, I have just assigned the ticket to you. Just to let you know, it's better if you wait a few days to start this one, a lot of things will be refactored on the matcher part once #206 is merged :)

Sure, thanks for the heads up :)

@Mth0158
Copy link
Collaborator Author

Mth0158 commented Nov 12, 2023

@chahmedejaz it's been merged if you want to start this one

@chahmedejaz
Copy link

Thanks for letting me know @Mth0158. I'll pick this up now :)

@Mth0158 Mth0158 added the enhancement New feature or request label Nov 12, 2023
@Mth0158
Copy link
Collaborator Author

Mth0158 commented Dec 1, 2023

Hi @chahmedejaz,
Any update on this PR?
FYI, the AspectRatioValidatorMatcher has already been developed by #153, sorry for that if you've coded it

@chahmedejaz
Copy link

Hi @chahmedejaz, Any update on this PR? FYI, the AspectRatioValidatorMatcher has already been developed by #153, sorry for that if you've coded it

Hey @Mth0158 - I'm working on it. Sorry I got overbooked with issues. I'll submit the PR soon, thanks for the update. 👍

@chahmedejaz chahmedejaz removed their assignment Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants