Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate total size of attachments in case of has_many relationship #113

Open
a-moreira opened this issue Apr 16, 2021 · 5 comments
Open
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@a-moreira
Copy link

This is a great gem, thanks a lot.
As far as I understand, it's not possible to validate the total file size (summation of each file size) in case we have a has_many relationship. For example, I have the following contraint:

  • upload some documents summing up to 10MB in size, each document with max 1MB each.

Currently I'm validating manually in the Model, but it'd be useful to have this in the gem as well.

I can try to implement it with some guidance.

@igorkasyanchuk igorkasyanchuk added the help wanted Extra attention is needed label May 7, 2021
@Mth0158
Copy link
Collaborator

Mth0158 commented Dec 1, 2023

Hi @a-moreira,
Thanks for raising this issue.
It seems like a nice addition to the gem. I can guide you on how to implement it, or I can do it myself if you are too busy right now.
Let me know!

@Mth0158 Mth0158 added enhancement New feature or request good first issue Good for newcomers and removed help wanted Extra attention is needed labels Dec 1, 2023
@a-moreira
Copy link
Author

hey @Mth0158, thanks for the reply. I'm busy right now so feel free to implement it :-)

@mattiasgullstrand
Copy link

Hi! Any updates on this feature? @Mth0158

@Mth0158
Copy link
Collaborator

Mth0158 commented Feb 16, 2024

Hi, @mattiasgullstrand I am busy these days, maybe I will find some time to implement it, but I can't say when...
It would be a nice addition to the gem though, feel free to assign it to yourself if you want to work on it :)

@mattiasgullstrand
Copy link

Thanks @Mth0158. I see, and I agree, would be a nice addition! But not sure that I will have time anytime soon either

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants