-
Notifications
You must be signed in to change notification settings - Fork 728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ARIA attribute to element that opens the Tooltip component #2120
Comments
Hello, I would like to assign myself this issue |
@PaxtonDevs Added you to our org! After accepting the invitation, you should be able to assign yourself to the issue. |
Awesome, thank you! |
Hi, if there is no further activity on this I'd like to contribute? |
Hi, I noticed this issue is still unresolved and would like to tackle it! I took a look at [#2156] and suggest possibly breaking this issue up into two smaller issues depending on if we want to write custom functionality for rendering HTML as a React Element or use one of the other libraries recommended by the old react-render-html maintainers. |
Is this issue still unresolved? I'd like to contribute. |
Description
In the Tooltip component (code), the element that opens the tooltip has an
aria-labelledby
attribute on it so that it can be associated with the element withrole="tooltip"
. This element that opens the tooltip does not have arole
itself. This will reduce the quality of the screen-reader experience.This is a problem because the
aria-labelledby
attribute cannot be used on adiv
with no valid role attribute.We don't want to assign a role to this
div
because it could contain an element of a different role. The ideal solution would be to addaria-labelledby={tooltipId}
to the child that is rendered i.e.{Utils.renderContent(element)}
.Please assign yourself (via the Assignees dropdown), if you do want to work on this issue. Can't find yourself? You need to join our organization.
Check out our Picking Up Issues guide if you haven't already!
The text was updated successfully, but these errors were encountered: