Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ARIA attribute to element that opens the Tooltip component #2120

Open
julianguyen opened this issue Oct 1, 2022 · 6 comments
Open

Add ARIA attribute to element that opens the Tooltip component #2120

julianguyen opened this issue Oct 1, 2022 · 6 comments

Comments

@julianguyen
Copy link
Member

julianguyen commented Oct 1, 2022

Description

In the Tooltip component (code), the element that opens the tooltip has an aria-labelledby attribute on it so that it can be associated with the element with role="tooltip". This element that opens the tooltip does not have a role itself. This will reduce the quality of the screen-reader experience.

This is a problem because the aria-labelledby attribute cannot be used on a div with no valid role attribute.

We don't want to assign a role to this div because it could contain an element of a different role. The ideal solution would be to add aria-labelledby={tooltipId} to the child that is rendered i.e. {Utils.renderContent(element)}.


Please assign yourself (via the Assignees dropdown), if you do want to work on this issue. Can't find yourself? You need to join our organization.

Check out our Picking Up Issues guide if you haven't already!

@julianguyen julianguyen changed the title Add ARIA attribute to element that opens tooltip Add ARIA attribute to element that opens the Tooltip component Oct 1, 2022
@ghost
Copy link

ghost commented Oct 5, 2022

Hello, I would like to assign myself this issue

@julianguyen
Copy link
Member Author

@PaxtonDevs Added you to our org! After accepting the invitation, you should be able to assign yourself to the issue.

@ghost ghost self-assigned this Oct 6, 2022
@ghost
Copy link

ghost commented Oct 6, 2022

Awesome, thank you!

@andomain
Copy link

Hi, if there is no further activity on this I'd like to contribute?

@jatinmark jatinmark self-assigned this Oct 27, 2022
@jatinmark jatinmark removed their assignment Nov 10, 2022
@a-camarillo
Copy link

Hi, I noticed this issue is still unresolved and would like to tackle it!

I took a look at [#2156] and suggest possibly breaking this issue up into two smaller issues depending on if we want to write custom functionality for rendering HTML as a React Element or use one of the other libraries recommended by the old react-render-html maintainers.

@reedjones
Copy link

Is this issue still unresolved? I'd like to contribute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants