Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Users to Add Members to Groups #1751

Open
GayathriVenkatesh opened this issue May 14, 2020 · 2 comments
Open

Allow Users to Add Members to Groups #1751

GayathriVenkatesh opened this issue May 14, 2020 · 2 comments

Comments

@GayathriVenkatesh
Copy link
Contributor

Description

As of now, we don't have a feature to add members to our groups. We need to first add a user to our Allies list, after which they can add themselves to our groups.

A possible issue with this is that the allies can view all our groups, and add themselves to any of them. It could so happen that we want a user to be part of only one group, and not be able to view/join any of the others.

We could tweak this feature such that only the creator of the group can add members. This means that the Allies won't be able to view the user's groups and join them directly.
Accepting an ally invitation could mean agreeing to be a part of any of their groups. But only the creator of the group can add these allies, to give more control to the user.

cc: @julianguyen


Please assign yourself (via the Assignees dropdown), if you do want to work on this issue. Can't find yourself? You need to join our organization.

Check out our Picking Up Issues guide if you haven't already!

@Manasa2850
Copy link
Member

@julianguyen I feel we could add a feature to the above description where we can accept/reject the group invite. This can help maintain privacy.

@julianguyen
Copy link
Member

Hey sorry for the late reply here! I've been focusing on helping to get all our existing PRs merged.

Thanks for suggesting this feature and putting together this issue :)

I don't think we should involve ally invitations in this. But I like @Manasa2850's idea of being able to accept/reject group invites.

Based on that:

  1. I think any group member should be able to send any of allies an invite to join a group.
  2. We already have group leaders and they're able to create meetings and remove people from them. I think a group leader should have the power to remove members from a group.

We'll need to handle this feature very similarly to how we handle ally invitations. We'll want to send in-app notifications and emails too.

I think a good place to start is to think about how we want to design the data models.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants