Don't override external specifications. See #20. #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think this is the right approach. See #20 (comment) |
ioggstream
commented
Feb 23, 2022
| schema to change within the same Schema Resource. | ||
| A dialect defining the `$schema` keyword: | ||
|
|
||
| * MUST do it according to the content of this section; |
There was a problem hiding this comment.
@jdesrosiers ensure that $schema is defined consistently btw various dialects
There was a problem hiding this comment.
I don't think this is quite the right perspective. $schema is not a keyword that dialects can define. It's a media type construct. So, we probably need to say something like, $schema is a reserved property that belongs to the media type and dialects MUST NOT define keywords that conflict with that name.
| * SHOULD define where the `$schema` keyword is allowed and/or | ||
| recognized in a schema; | ||
| * SHOULD not allow the | ||
| schema to change within the same Schema Resource. |
There was a problem hiding this comment.
"Schema resource" should probably be referenced .
There was a problem hiding this comment.
Agreed. Schema Reference and Schema Document need to be defined.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
References external spec instead of overriding them
Note
If
$schemais defined into JSONSchema, probably we should just reference it.