Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support IE11 (and other older browsers) #636

Open
jfilter opened this issue Apr 29, 2020 · 1 comment
Open

Support IE11 (and other older browsers) #636

jfilter opened this issue Apr 29, 2020 · 1 comment

Comments

@jfilter
Copy link

jfilter commented Apr 29, 2020

Is your feature request related to a problem? Please describe.
Call me naive, but I really thought that Idyll would support IE11. It is still used by over 5% of desktop users.

Describe the solution you'd like
idyll build should make use of babel to transpile code that runs on IE11.

Describe alternatives you've considered
Not supporting older browsers. But then make it clear in the documentation.

@mathisonian
Copy link
Member

Thanks for bringing this up @jfilter. I think the main culprits for the IE errors are coming from here where code is being dynamically generated, so it doesn't get transpiled.

At a quick glance there are two issues which will need to be updated to work with IE:

  • Arrow functions
  • Proxy objects

The handle the arrow functions we could just modify the existing code so it only uses the function keyword. Proxy objects are a little bit trickier, but there is a polyfill.

We could perhaps have users who want to support IE11 opt-in to including the polyfill?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants