Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking of Python 3.11 compatibility #337

Open
6 of 9 tasks
C4ptainCrunch opened this issue Jun 1, 2022 · 4 comments
Open
6 of 9 tasks

Tracking of Python 3.11 compatibility #337

C4ptainCrunch opened this issue Jun 1, 2022 · 4 comments

Comments

@C4ptainCrunch
Copy link
Member

C4ptainCrunch commented Jun 1, 2022

Python 3.11 tests are failing since a few hours, this is due to a legit bug in Python and is tracked on pytest-dev/pytest#10008 and python/cpython#93359. This should be fixed with the next pre-release of Python.

This issue also keep track of the stable release that is currently targeted for 2022-10-03. At that time, we should:

  • Change the build matrix to disallow 3.11 tests to fail
  • Enforce 3.11 tests in the branch protection
  • Add 3.12 in the tests (as experimental) ?
  • Update PyPi classifiers
  • Build with 3.11 on ReadThe Docs (.readthedocs.yaml)
  • Build tox targets docs and checks on 3.11

Edit:

@C4ptainCrunch
Copy link
Member Author

They released a new version of Python quite quickly : https://twitter.com/pyblogsal/status/1532043180631375879
I re-ran the test and it's all green again 🎉

@N-Coder
Copy link
Member

N-Coder commented Jun 5, 2022

We might also want to include these steps in general as a "Updating for a newly-released python version" section in the docs. As a refence we can also take the changes made in #301 and #338. I'd also include:

@N-Coder
Copy link
Member

N-Coder commented Jul 11, 2022

And also for deprecating old versions:

  • update pyproject.toml and tox.ini
  • update --py37-plus for pyupgrade in .pre-commit-config.yaml
  • check for compatibility imports, e.g. cached_property, stuff from typing, importlib_resources,...

@C4ptainCrunch
Copy link
Member Author

Update: we are almost there. We are only missing 3.12 experimental tests and maybe PyPy and mypy (but that can be done later)
I'm also considering releasing 0.8.0dev1 with the changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants