Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add integration tests #118

Merged
merged 7 commits into from Aug 1, 2023
Merged

feat: Add integration tests #118

merged 7 commits into from Aug 1, 2023

Conversation

liurenjie1024
Copy link
Contributor

@liurenjie1024 liurenjie1024 commented Jul 26, 2023 •
edited

Closes #57

@liurenjie1024 liurenjie1024 marked this pull request as draft July 26, 2023 08:54
@liurenjie1024 liurenjie1024 changed the title Integration tests with trino. Integration tests Jul 28, 2023
@liurenjie1024 liurenjie1024 force-pushed the renjie/issue-57 branch 2 times, most recently from 043f83f to 5943d29 Compare August 1, 2023 09:55
@liurenjie1024 liurenjie1024 marked this pull request as ready for review August 1, 2023 10:09
@liurenjie1024
Copy link
Contributor Author

cc @Xuanwo @ZENOTME This is ready for review.

Xuanwo
Xuanwo reviewed Aug 1, 2023
View reviewed changes
Copy link
Contributor

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

icelake/src/table.rs Show resolved Hide resolved
icelake/src/table.rs Show resolved Hide resolved
icelake/src/table.rs Show resolved Hide resolved
icelake/src/transaction.rs Show resolved Hide resolved
tests/integration/rust/src/main.rs Show resolved Hide resolved
This was referenced Aug 1, 2023
Closed
Open
@Xuanwo Xuanwo changed the title Integration tests feat: Add integration tests Aug 1, 2023
Xuanwo
Xuanwo approved these changes Aug 1, 2023
View reviewed changes
Copy link
Contributor

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's move on!

@liurenjie1024 liurenjie1024 merged commit 1feb3a9 into icelake-io:main Aug 1, 2023
4 checks passed
@liurenjie1024 liurenjie1024 deleted the renjie/issue-57 branch August 1, 2023 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xuanwo Xuanwo Xuanwo approved these changes

@ZENOTME ZENOTME Awaiting requested review from ZENOTME

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Integration test of file writer.
2 participants
@liurenjie1024 @Xuanwo