Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

split in_memory module like on_disk #106

Open
ZENOTME opened this issue Jul 20, 2023 · 3 comments
Open

split in_memory module like on_disk #106

ZENOTME opened this issue Jul 20, 2023 · 3 comments

Comments

@ZENOTME
Copy link
Contributor

ZENOTME commented Jul 20, 2023

I find that in_memory.rs is so long, do we consider to split into manifest_file, manifest_list like on_disk?

cc @liurenjie1024 @Xuanwo
@Xuanwo
Copy link
Contributor

Xuanwo commented Jul 20, 2023

Is this issue preventing us from adding a new feature? If not, I would prefer to address it during the v0.1 polishing stage.

@ZENOTME
Copy link
Contributor Author

ZENOTME commented Jul 20, 2023

I think not yet. Let's address it during the v0.1 polishing stage.

@liurenjie1024
Copy link
Contributor

Agree that we should postpone it after we have implemented basic functions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@liurenjie1024 @Xuanwo @ZENOTME