New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement partition summary for mainfest writer. #102

Open

Tracked by

liurenjie1024 opened this issue Jul 18, 2023 · 3 comments

Open

Tracked by

Implement partition summary for mainfest writer. #102

liurenjie1024 opened this issue Jul 18, 2023 · 3 comments

Contributor

liurenjie1024 commented Jul 18, 2023

https://github.com/liurenjie1024/icelake/blob/99d8d92a7cc8a40c86bc1ab84da4798cd89f1f19/src/types/on_disk/manifest_file.rs#L393

icelake/src/types/on_disk/manifest_file.rs

Line 393 in 99d8d92

let mut writer = AvroWriter::new(avro_schema, Vec::new());

Contributor

ZENOTME commented Jul 20, 2023 •

edited

https://iceberg.apache.org/spec/#partitioning:~:text=Partition%20data%20tuple%2C%20schema%20based%20on%20the%20partition%20spec%20output%20using%20partition%20field%20ids%20for%20the%20struct%20field%20ids

This should do after we support partition in data file, I find that this sumary is computed from the partiton in data file.

Contributor

ZENOTME commented Jul 20, 2023

BTW, do we prepare to support partition in 0.1 veriosn? It seems the whole API can build without partition.

Contributor Author

liurenjie1024 commented Jul 20, 2023

Yes, it's necessary for practical use.

ZENOTME mentioned this issue

Tracking: Support partition write #114

Open

3 tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment