Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shrink/Extend main pane does not work for extended custom layouts #1550

Open
Henkru opened this issue Sep 17, 2023 · 0 comments · May be fixed by #1551
Open

Shrink/Extend main pane does not work for extended custom layouts #1550

Henkru opened this issue Sep 17, 2023 · 0 comments · May be fixed by #1551

Comments

@Henkru
Copy link
Contributor

Henkru commented Sep 17, 2023

Describe the bug
If a custom layout extends a layout that uses a main pane (e.g. 3Column Middle), then Shrink/Extend main pane & Increase/Decrease main pane count shortcuts do not have any affect.

To Reproduce
The following custom layout can be used to reproduce the issue.

function layout() {
  return {
    name: "test",
    extends: "middle-wide",
    getFrameAssignments: (windows, screenFrame, state, extendedFrames) => {
      return extendedFrames.reduce((frames, extendedFrame) => {
        return { ...frames, [extendedFrame.id]: extendedFrame.frame };
      }, {});
    }
  };
}
  1. Load the above custom layout
  2. Try to shrink the main pane

Expected behavior
The above custom layout extends the 3Column Middle layout, and the Shrink/Extend main pane & Increase/Decrease main pane count shortcuts should work normally.

Versions:

  • macOS: Ventura 13.5
  • Amethyst: 0.20.0 (108)

Debug Info

ersion: 0.20.0 (108)

OS version: Version 13.5 (Build 22G74)

Screens:
	(0.0, 0.0, 5120.0, 1440.0) [(0.0, 0.0, 5120.0, 1440.0)]
	(1910.0, -1080.0, 1920.0, 1080.0) [(1910.0, 1440.0, 1920.0, 1080.0)]

Configuration:
smart-window-margins: 0
new-windows-to-main: 0
mod2: (
    option,
    shift,
    control,
    command
)
float-small-windows: 1
screen-padding-left: 0
mod1: (
    option,
    shift,
    command
)
window-minimum-width: 0
restore-layouts-on-launch: 1
use-canary-build: 0
window-margins: 1
mouse-resizes-windows: 1
floating-is-blacklist: 1
debug-layout-info: 0
enables-layout-hud: 1
follow-space-thrown-windows: 1
ignore-menu-bar: 0
floating: (
)
window-resize-step: 5
window-max-count: 0
enables-layout-hud-on-space-change: 0
layouts: (
    test,
    "middle-wide"
)
screen-padding-bottom: 0
window-minimum-height: 0
screen-padding-right: 0
mouse-swaps-windows: 1
focus-follows-mouse: 0
mouse-follows-focus: 0
screen-padding-top: 0
window-margin-size: 10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Proxies PanedLayout function calls to extended layouts Henkru/Amethyst
1 participant
@Henkru