Request (Style Programically) #11
Comments
|
Sweet |
|
let me know when you have issues. Since it has not been merged with the upstream branch, you may need to go to jitpack to get my build |
|
Alright, il give this a go sometime later. Working on a main project atm |
|
How do we include your build in a project? The documentation in your github still points to this project instead. What specifically is the Gradle implementation/api syntax for your build in jitpack? |
|
@ryust use this build i updated my README, you can check it out at https://github.com/kojofosu/MultiSearchView |
|
Thanks for the update. Unfortunately, I wasn't able to get things to work. It would be sooooooooo much simpler if there was a getter method on the EditText so that I can easily change items programmatically (like hint) instead of messing around with XML styles and trying to hook it all together when using multiple 3rd party libraries. |
|
@ryust your request seems to be on the edittext itself rather than the icon ..am I right? If yes, i think i can work on that for you |
|
Yes, exactly. The original post request was to set styles programmatically… regardless of the widget. So getter methods is the easiest way to access underlying components so developers have the most flexibility to modify the widgets via code (not XML). I’m surprised the original library didn’t have it, but apparently that developer has abandoned the project. Thanks for taking it over!
… On Jul 19, 2021, at 8:56 AM, Kojo Fosu Bempa Edue ***@***.***> wrote:
@ryust <https://github.com/ryust> your request seems to be on the edittext itself rather than the icon ..am I right? If yes, i think i can work on that for you
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#11 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AACGR4SXYMU4QZ5LQOM7KNLTYQVHHANCNFSM4QP6IQXQ>.
|
Any idea when you could get something working? If awhile, then I'll look at other search libraries. This one looked good, but it's very inflexible in customization... I just can't get the styles XML method to work in my project. |
|
Will Friday be too far out for you? Currently wrapping up on another
library I'm building .
…On Wed, 21 Jul 2021, 2:22 pm Ron Yust, ***@***.***> wrote:
@ryust <https://github.com/ryust> your request seems to be on the
edittext itself rather than the icon ..am I right? If yes, i think i can
work on that for you
Any idea when you could get something working? If awhile, then I'll look
at other search libraries. This one looked good, but it's very inflexible
in customization... I just can't get the styles XML method to work in my
project.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#11 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AE2ERLWYZDDQDF7OIN6CU3LTY3JY7ANCNFSM4QP6IQXQ>
.
|
|
Friday will work. Thanks! |
|
@ryust I've added getter and setter method to change search hint...will have time to make the editext itself accessible. Are there any other customizations you would like me to prioritize? |
|
Thanks! The hint was the most important attribute, but having complete control of the EditText is ideal. I'll work with what you've done. |
|
@ryust alright, let me know if there are any issues. And to change the hint, you will need to remove the line that sets the "style" for the search view in the xml |
|
Well.... that's the core of my problem... I don't use XML layouts and create UI views programmatically. So if I have to mess with styles and XML, then I'm back to my original problem... I won't be able to use what you've done. |
|
@ryust you don't need xml for that. you can do everything programmatically now. Just try it and let me know how it goes |
|
OK, I got the hint to work and that works well, but have a couple other issues with the new library:
|
|
Alright. I'll look into that for you !
…On Fri, 23 Jul 2021, 8:50 pm Ron Yust, ***@***.***> wrote:
OK, I got the hint to work and that works well, but have a couple other
issues with the new library:
1.
I wanted change the icon color programmatically, but it appears that
the setSearchIconColor expects an argument of a color resource... I want to
use a Color directly instead.
2.
When creating multiple search items, the length of each is much wider
than the original library... to the point that you can't see multiple items
at the same time in the search.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#11 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AE2ERLTBC4LYKUWFFKM7ZU3TZHI2RANCNFSM4QP6IQXQ>
.
|
|
Great! And I also need the ability to tint the hint for dark mode colors. :) |
|
alright |
|
@ryust kindly check version 0.6 |
|
That version is not found. Gradle can't find it. |
|
try again..Jitpack didn't finish building at that time..my bad @ryust |
|
I'm about to give up on the library. Now creating MultiSearchView programmatically (as I've done before) results in a NPE: java.lang.NullPointerException |
|
@ryust i apologize once again. These were quick fixes and i didnt really test for the nullpointer exception. But that has been fixed in 0.7 now. |
|
|
And the width of the search items still take up the full width of the parent view unlike the original library so you can't really see more than one search item at a time. |
|
setHintColor(Integer value) What exactly is Integer? Resource id? Color int? |
how are you setting the color? |
i am not able to replicate this issue ... that's why i havent been able to fix it.. My search results do not take up the whole widht... could you tell me what your hint says and also how long it is |
resource id...but the is also another method to set the color using color string . e.g. "#FFFFFF" for white |
|
The hint is long, but I didn't realize it would expand all the search items... kinda pointless then to allow a hint change if only realistically limited to something small like "Search". There is only one setHintColor method which requires an Integer. The other method using a string is for setIconColor. This is really a nice search implementation, but it appears the original design was more of a showcase than a library for flexibility and customization. I'm really reevaluating using something else. This shouldn't be so difficult for such a small library. |
|
alright, im doing my best here...sorry if it doesn't meet your expectations....but i am not writing the library from scratch ...only adding to the already existing working product... I also didnt add the hint color using a string because you didnt request for it ..and i was rushing trying to get what you requested for as quick as possible for you to continue what you are working on |
|
I appreciate your efforts... no blame towards you. It just appears the library was never designed to be customized like other libraries are. If there was getter methods for the underlying components, then that would provide the ultimate flexibility without you having to keep adding API changes. |
|
I'm replacing the long hint with a Toast message to explain what the search is for which bypasses the long hint causing the bigger search items. If you can get both the icon and hint colors changed via a Color int, then I can implement the library. Thanks for all the effort you've done. |
|
for clarity, could you send me a code snippet of how you would want to set the color using the color int @ryust |
|
setHintColor(int colorInt); |
no, not that. Not the method's construction... but the implementation. How you are setting it not how you want me to construct it... i dont know if i am making sense. I want to know how your input parameter . A snippet of that. |
|
MultiSearchView view = new MultiSearchView(context); |
|
Ok ..i see . But you could just pass the color string i.e String baseColor = "#FFFFFF";
view.setHintColor(baseColor);
view.setIconColor(baseColor);.Does that work well for you or you still insist to use it like how you've stated above? |
|
I'm fine with the way it is. Thanks again. |
|
alright then kindly check v0.8.. hopefully there are no errors |
|
v0.8 is crashing on startup... v0.7 was working fine. I am not setting hint or icon colors. |
|
Correction... I am setting hint color, but not icon color. The stack trace starts with the setHintColor using a Color int. |
|
Color setting really should be similar to TextView... setTextColor(int colorInt), setTextColor(ColorStateList colorList, and setTextAppearance(int resId) Developers will not know what the int should be for setHintColor and will likely do as accustomed with other widgets... like TextView... by supplying a color int to setHintColor. |
The int there is for resource id. e.g |
okay..for the next update, i will build a snapshot for you ...so you test and give feedback before i create a release tag for it |
|
@ryust implement this in your gradle If all your requirements are met concerning colors, then i create a release tag |
|
That's fine... I got around the issue by converting the color int into a string and then using the existing method with the string argument. |
|
okay ..but then i made your request ..so if you want to check it out . But i doubt you have time to test the snapshot out so i'll just put that in a new release |
Setting a style via xml doesn't really help in an app where the gui dynamically changes based on colors. I would enjoy the ability to tint the search icon and text via code.
The text was updated successfully, but these errors were encountered: