This repository has been archived by the owner on Jul 15, 2020. It is now read-only.
Review and make improvements for accessibility #58
Labels
Comments
|
A lang property has now been added to all pages. The new menu toggle now has an aria-label property. |
iaincollins
added a commit
that referenced
this issue
Jan 15, 2018
* Replaced navbar and dropdown menu driven by CSS in nojs-menus.scss. * Added animation to mobile menu toggle. * Moved ‘Sign out’ menu back to the navbar now that dropdown menus work without JS. This resolves #57 (Reactstrap menus not working on mobile and also not working without JS) but impacts #58. Resolving the accessibility issues while preserving menus that work without JS across browsers will likely require adding hooks in JavaScript specifically for acessibility behaviour. This has been tested in Chrome, Firefox, Safari, Internet Explorer and on iOS and Andrioid.
|
I've refactored all menus (the main nav menu, dropdown) to be entirely CSS based, and not require client side JavaScript. I'm concerned, however, that this has made them less accessible, because they rely on using :focus. Any feedback on how accessibility is impacted or could be improved - even if it involves adding optional JavaScript hooks to the menus, is much appreciated. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
This starter project should set a better example by being more accessible.
Fixes for issues issues are most welcome.
Raising bugs for specific accessibility issues is also very welcome.
The text was updated successfully, but these errors were encountered: