Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DrawText() always left-aligns glyphs even when they specify an offset in BBX field #1521

Open
ty-porter opened this issue Mar 5, 2023 · 0 comments · May be fixed by #1534
Open

DrawText() always left-aligns glyphs even when they specify an offset in BBX field #1521

ty-porter opened this issue Mar 5, 2023 · 0 comments · May be fixed by #1534

Comments

@ty-porter
Copy link

ty-porter commented Mar 5, 2023

Hi! I maintain mlb-led-scoreboard which leverages this library.

We have had an issue reported where users noticed some strange alignment issues for some characters.
MLB-LED-Scoreboard/mlb-led-scoreboard#416 (comment)

Our default font is tom-thumb.bdf. Any glyphs which specify an X offset in their BBX field will be left-aligned instead of correctly aligned by the bounding box. An example character is !, where BBX 1 5 1 0 uses the third column to set a X-offset of +1.

STARTCHAR exclam
ENCODING 33
SWIDTH 1000 0
DWIDTH 4 0
BBX 1 5 1 0
BITMAP
80
80
80
00
80
ENDCHAR

Picture of some other characters (!, i, :, . are affected, x for reference spacing):
Example

I was able to trace it down to 39953b7. Our previous advice to end users was to revert back to a56338d, but that commit is over a year old at this point.

@WardBrian WardBrian linked a pull request Apr 18, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant