Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic deletion mechanism is broken #26

Open
Kogerro opened this issue Oct 15, 2019 · 0 comments
Open

Automatic deletion mechanism is broken #26

Kogerro opened this issue Oct 15, 2019 · 0 comments

Comments

@Kogerro
Copy link

Kogerro commented Oct 15, 2019

Automatic deletion mechanism of old logs is broken. It is based on incorrect assumption, that each log line should start with a time stamp like 2017-10-05T14:46:36.541Z, and chooses logs to delete by simple string comparison of whole log line and string made from date before which logs should be deleted.

This causes two major problems:

  • if there's no such time stamp, old logs won't be ever automatically deleted
  • logs starting with strings "lower" than string made from date before which logs should be deleted are automatically deleted.

It took me a long search to find why all my logs starting with custom date "dd/mm" are removed between Hyperlog initializations - it was simply because it made log lines start with '0', while string made from date before which logs should be deleted always started with '2'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant