Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace @types/rdf-js with @rdfjs/types #122

Open
jeswr opened this issue Feb 6, 2024 · 7 comments
Open

Replace @types/rdf-js with @rdfjs/types #122

jeswr opened this issue Feb 6, 2024 · 7 comments

Comments

@jeswr
Copy link

jeswr commented Feb 6, 2024

Usage of @types/rdf-js should be @rdfjs/types instead. See https://github.com/rdfjs/types?tab=readme-ov-file#what-about-typesrdf-js

This was discovered in the same way as jacoscaz/quadstore#167 (comment).

"@types/rdf-js": "^4",

@tpluscode
Copy link
Member

tpluscode commented Feb 6, 2024

Curious, are you automatically generating this and similar issues? Because you dug up some real old repos :)

@jeswr
Copy link
Author

jeswr commented Feb 6, 2024

I was trying to pin down some warnings that I was getting from components.js building the Community Solid Server so I ran the following search to see what uses of @types/rdf-js were still in use

https://github.com/search?q=%22%5C%22%40types%2Frdf-js%5C%22%3A+%5C%22%22+language%3AJSON&type=code

@tpluscode
Copy link
Member

I got that from the linked issue. I wonder about the technique of creating these issues. There are 600+ matches for @types/rdf-js :)

And by the way, we should also discourage usages of rdf-js. Another 400+ hits on public GitHub... You probably noticed that I did that recently in DT.

@jeswr
Copy link
Author

jeswr commented Feb 6, 2024

I wonder about the technique of creating these issues. There are 600+ matches for @types/rdf-js :)

Aha - I'm just going through the first couple of pages worth of non-archived repos by hand (filtering out forks also brings the number down to 300). Sorry for any noise created on repo's that aren't in use much anymore.

@jeswr
Copy link
Author

jeswr commented Feb 6, 2024

And by the way, we should also discourage usages of rdf-js. Another 400+ hits on public GitHub... You probably noticed that I did that recently in DT.

Agreed - looks like you have write permissions for https://www.npmjs.com/package/rdf-js; perhaps you could mark it as deprecated (per https://docs.npmjs.com/deprecating-and-undeprecating-packages-or-package-versions)

@tpluscode
Copy link
Member

Good point. Thanks

@tpluscode
Copy link
Member

Done, and updated the readme (rdfjs/types#40)

I tweaked your search terms a little. In addition to excluding forks, I also excluded archived repos and match only package.json. Only 139 hits :)

https://github.com/search?q=%22%5C%22%40types%2Frdf-js%5C%22%3A+%5C%22%22+language%3AJSON++NOT+is%3Aarchived+NOT+is%3Afork+path%3A%2Fpackage.json%24%2F&type=code

And 69 of rdf-js

https://github.com/search?q=%22%5C%22rdf-js%5C%22%3A+%5C%22%22+language%3AJSON++NOT+is%3Aarchived+NOT+is%3Afork+path%3A%2Fpackage.json%24%2F&type=code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants