Skip to content
This repository has been archived by the owner on Feb 1, 2024. It is now read-only.

iOS and Android native modules have different method signatures #5

Open
jakubkoci opened this issue Jul 19, 2021 · 0 comments
Open

Comments

@jakubkoci
Copy link
Contributor

This has been copied from AbsaOSS/rn-indy-sdk#25

@TimoGlastra wrote:
See the code samples below. for example proverCreateCredentialReq for iOS and Android sides expect different order of parameters. I guess because they match the native indy library for iOS/Android.

However I think we should abstract that away on the native side and make the call from the JS side the same for both.

https://github.com/AbsaOSS/rn-indy-sdk/blob/43aff51c158cb871c12ce4247aa7df74690e51da/android/src/main/java/com/reactlibrary/IndySdkModule.java#L507

https://github.com/AbsaOSS/rn-indy-sdk/blob/43aff51c158cb871c12ce4247aa7df74690e51da/ios/IndySdk.swift#L302-L304

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

No branches or pull requests

1 participant