Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transpile module output for package.json #57

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

farneman
Copy link
Contributor

@farneman farneman commented May 7, 2017

This fixes #56 by adding an ./es directory that is created via NPM's prepare command on publish and install. The files from ./src are transpiled to ES5 there via Babel while keeping the module syntax.

I also added a similar command to the Makefile if it's helpful. I'm not very familiar with JSPM or its use of Makefiles so let me know if that needs to be changed or removed.

@farneman
Copy link
Contributor Author

Updated to fix conflicts with the current master.

@iptpv
Copy link

iptpv commented Jun 20, 2017

👍

@TheRealAlan
Copy link

We ran into an issue where the es2015 version was always automatically used, even with the .cjs version should have been, which may or may not have been caused by this. Is there a reason why this PR was never merged?

@jan-dh
Copy link

jan-dh commented Jun 22, 2018

I'm running into an issue with ES2015 version as well (using webpack 4 and the import statement). Can anyone confirm if this PR solves this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

package.json module property reference should not include ES2015+ features
4 participants